Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error handling for op code CREATE2 #1587

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

dusan-maksimovic
Copy link
Contributor

@dusan-maksimovic dusan-maksimovic commented Jun 5, 2023

Description

This PR introduces fix for this and this issue.
The error handling wasn't done the right way so the state was reverted but the op code CREATE2 was reporting the success. This is now fixed to match the way errors for CREATE2 are handled in go-ethereum. See the go-ethereum error handling here.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@dusan-maksimovic dusan-maksimovic requested a review from a team June 5, 2023 10:27
@dusan-maksimovic dusan-maksimovic self-assigned this Jun 5, 2023
@dusan-maksimovic dusan-maksimovic added the bug fix Functionality that fixes a bug label Jun 5, 2023
@dusan-maksimovic dusan-maksimovic merged commit 2c2c45d into develop Jun 5, 2023
6 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2023
@dusan-maksimovic dusan-maksimovic deleted the EVM-663-create-not-return-failure branch June 5, 2023 12:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants