Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM-707 Remove balance field from initial validators in genesis.json #1736

Merged
merged 2 commits into from
Jul 21, 2023
Merged

EVM-707 Remove balance field from initial validators in genesis.json #1736

merged 2 commits into from
Jul 21, 2023

Conversation

igorcrevar
Copy link
Contributor

Description

We should remove Balance field from initial validators list in genesis.json since its not used anywhere anymore.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@igorcrevar igorcrevar requested a review from a team July 20, 2023 13:32
@igorcrevar igorcrevar self-assigned this Jul 20, 2023
@Stefan-Ethernal Stefan-Ethernal requested a review from a team July 20, 2023 14:40
@Stefan-Ethernal Stefan-Ethernal changed the title EVM-707 Remove field from initial validators in genesis.json EVM-707 Remove balance field from initial validators in genesis.json Jul 21, 2023
@igorcrevar igorcrevar merged commit 72e2c4b into develop Jul 21, 2023
6 checks passed
@igorcrevar igorcrevar deleted the feature/EVM-707_remove_balance_from_initial_validator_set branch July 21, 2023 09:27
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2023
@Stefan-Ethernal Stefan-Ethernal changed the title EVM-707 Remove balance field from initial validators in genesis.json EVM-707 Remove balance field from initial validators in genesis.json Jul 21, 2023
@Stefan-Ethernal Stefan-Ethernal changed the title EVM-707 Remove balance field from initial validators in genesis.json EVM-707 Remove balance field from initial validators in genesis.json Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelacamarko jelacamarko jelacamarko approved these changes

@rachit77 rachit77 rachit77 approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

Assignees

@igorcrevar igorcrevar

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@igorcrevar @jelacamarko @rachit77 @Stefan-Ethernal