Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed seal parameter #1886

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Removed seal parameter #1886

merged 2 commits into from
Oct 10, 2023

Conversation

jelacamarko
Copy link
Contributor

@jelacamarko jelacamarko commented Sep 7, 2023 •
edited

Description

Removed seal parameter.
I added the Validator field in TestServerConfig. The previous Seal field was used for the TestCluster Stats Log

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@jelacamarko jelacamarko self-assigned this Sep 7, 2023
@jelacamarko jelacamarko requested a review from a team September 7, 2023 12:57
@jelacamarko jelacamarko marked this pull request as ready for review September 7, 2023 12:57
@Stefan-Ethernal
Copy link
Contributor

@gatsbyz @praetoriansentry folks, just a heads up, this PR removes the --seal parameter from the server command (since it was not doing anything), so when and if it gets merged, you should remove it from deployment scripts as well.

vcastellm
vcastellm approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelacamarko
Merge branch 'develop' into evm-635-remove-seal-parameter
15f84c6 
# Conflicts:
#	e2e-polybft/framework/test-cluster.go
#	e2e-polybft/framework/test-server.go
@jelacamarko jelacamarko merged commit 4d379fd into develop Oct 10, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the evm-635-remove-seal-parameter branch October 11, 2023 09:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@dusan-maksimovic dusan-maksimovic dusan-maksimovic approved these changes

Assignees

@jelacamarko jelacamarko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jelacamarko @Stefan-Ethernal @vcastellm @dusan-maksimovic