Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base Fee Configs #1890

Merged
merged 17 commits into from
Oct 4, 2023
Merged

Base Fee Configs #1890

merged 17 commits into from
Oct 4, 2023

Conversation

rachit77
Copy link
Contributor

@rachit77 rachit77 commented Sep 7, 2023 •
edited

Description

This PR adds the functionality to provide initial baseFee, baseFeeEM at the time of genesis file creation.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@rachit77 rachit77 added the feature New update to Polygon Edge label Sep 7, 2023
@rachit77 rachit77 self-assigned this Sep 7, 2023
Stefan-Ethernal
Stefan-Ethernal approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from Igor's comment and minor comment from my end LGTM.

command/genesis/genesis.go Outdated Show resolved Hide resolved
Stefan-Ethernal
Stefan-Ethernal reviewed Sep 13, 2023
View reviewed changes
command/genesis/polybft_params.go Outdated Show resolved Hide resolved
command/genesis/genesis.go Outdated Show resolved Hide resolved
Stefan-Ethernal
Stefan-Ethernal reviewed Sep 14, 2023
View reviewed changes
command/genesis/params.go Outdated Show resolved Hide resolved
command/genesis/params.go Outdated Show resolved Hide resolved
@Stefan-Ethernal
Copy link
Contributor

Not sure why we have not merged this PR?

@rachit77 Anyways, now that #1934 got merged, it is worth considering should we provide baseFeeChangeDenom configuration parameter with baseFeeConfig as well. WDYT?

@rachit77 rachit77 changed the title added genesis base fee flag Base Fee Configs Oct 4, 2023
Stefan-Ethernal
Stefan-Ethernal reviewed Oct 4, 2023
View reviewed changes
command/genesis/params.go Outdated Show resolved Hide resolved
command/genesis/params.go Show resolved Hide resolved
command/genesis/genesis.go Outdated Show resolved Hide resolved
command/genesis/genesis.go Outdated Show resolved Hide resolved
command/genesis/params.go Outdated Show resolved Hide resolved
command/genesis/polybft_params.go Outdated Show resolved Hide resolved
Stefan-Ethernal
Stefan-Ethernal reviewed Oct 4, 2023
View reviewed changes
command/genesis/utils.go Outdated Show resolved Hide resolved
command/genesis/utils.go Outdated Show resolved Hide resolved
command/genesis/utils.go Outdated Show resolved Hide resolved
command/genesis/utils.go Outdated Show resolved Hide resolved
command/genesis/utils.go Outdated Show resolved Hide resolved
@rachit77 rachit77 merged commit 1f8c9c6 into develop Oct 4, 2023
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2023
@vcastellm vcastellm deleted the EVM-824 branch October 4, 2023 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@dusan-maksimovic dusan-maksimovic dusan-maksimovic left review comments

@stana-miric stana-miric stana-miric approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@jelacamarko jelacamarko Awaiting requested review from jelacamarko

Assignees

@rachit77 rachit77

Labels
feature New update to Polygon Edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rachit77 @Stefan-Ethernal @igorcrevar @dusan-maksimovic @stana-miric