Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM-831 Implement state sync relayer without blocktracker #1899

Merged
merged 27 commits into from
Oct 17, 2023
Merged

EVM-831 Implement state sync relayer without blocktracker #1899

merged 27 commits into from
Oct 17, 2023

Conversation

igorcrevar
Copy link
Contributor

@igorcrevar igorcrevar commented Sep 8, 2023 •
edited

Description

State sync relayer should not depend on blocktracker but should be part of consensus runtime like all the other similar parts.

Consensus runtime should call state sync relayer PostBlock(req *common.PostBlockRequest) error every time new block is inserted. State sync relayer should parse all the events and should submit transaction for each of those. It also internally remembers next event ID and next block number that should be processed (because sometimes something can go wrong).

Flag --relayer-poll-interval will be removed because its not used anymore

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@igorcrevar igorcrevar added the bug fix Functionality that fixes a bug label Sep 8, 2023
@igorcrevar igorcrevar requested a review from a team September 8, 2023 09:51
@igorcrevar igorcrevar self-assigned this Sep 8, 2023
@igorcrevar igorcrevar force-pushed the feature/state_sync_relayer_refactor branch 5 times, most recently from dd821d3 to 2eb8315 Compare September 8, 2023 15:11
@igorcrevar igorcrevar marked this pull request as ready for review September 9, 2023 12:47
@igorcrevar igorcrevar marked this pull request as draft September 11, 2023 08:45
@goran-ethernal goran-ethernal force-pushed the feature/state_sync_relayer_refactor branch from 3012cb9 to 55e704e Compare October 4, 2023 08:56
@igorcrevar igorcrevar force-pushed the feature/state_sync_relayer_refactor branch 10 times, most recently from 1b32fe2 to 7d4c792 Compare October 10, 2023 14:49
@igorcrevar igorcrevar force-pushed the feature/state_sync_relayer_refactor branch 4 times, most recently from f5cad29 to fe8a08c Compare October 13, 2023 11:59
@igorcrevar igorcrevar marked this pull request as ready for review October 13, 2023 13:15
@goran-ethernal goran-ethernal force-pushed the feature/state_sync_relayer_refactor branch from 047c3c9 to 94e0f58 Compare October 16, 2023 14:35
goran-ethernal
goran-ethernal approved these changes Oct 17, 2023
View reviewed changes
consensus/polybft/state_sync_relayer.go Outdated Show resolved Hide resolved
consensus/polybft/state_sync_relayer.go Outdated Show resolved Hide resolved
@dusan-maksimovic dusan-maksimovic requested a review from a team October 17, 2023 08:22
Stefan-Ethernal
Stefan-Ethernal reviewed Oct 17, 2023
View reviewed changes
command/genesis/params.go Outdated Show resolved Hide resolved
consensus/consensus.go Show resolved Hide resolved
consensus/polybft/consensus_runtime.go Outdated Show resolved Hide resolved
consensus/polybft/state_sync_relayer.go Show resolved Hide resolved
e2e-polybft/framework/test-cluster.go Outdated Show resolved Hide resolved
consensus/polybft/consensus_runtime.go Outdated Show resolved Hide resolved
consensus/polybft/consensus_runtime.go Outdated Show resolved Hide resolved
consensus/polybft/state_sync_relayer.go Outdated Show resolved Hide resolved
consensus/polybft/state_sync_relayer.go Outdated Show resolved Hide resolved
consensus/polybft/state_sync_relayer.go Show resolved Hide resolved
@igorcrevar igorcrevar merged commit 4efe1d7 into develop Oct 17, 2023
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the feature/state_sync_relayer_refactor branch October 20, 2023 07:39
@Stefan-Ethernal Stefan-Ethernal linked an issue Oct 25, 2023 that may be closed by this pull request
Failed state sync executions are not retried #1811
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@dusan-maksimovic dusan-maksimovic dusan-maksimovic approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@igorcrevar igorcrevar

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed state sync executions are not retried
4 participants
@igorcrevar @Stefan-Ethernal @dusan-maksimovic @goran-ethernal