Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WithoutBridge configuration param from e2e framework #1919

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

Stefan-Ethernal
Copy link
Contributor

Description

This PR removes the WithoutBridge configuration option from polybft e2e framework, since polybft requires a bridge at all times, because of rootchain staking.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal requested a review from a team September 19, 2023 10:16
@Stefan-Ethernal Stefan-Ethernal self-assigned this Sep 19, 2023
@Stefan-Ethernal Stefan-Ethernal merged commit 5f6ba3e into develop Sep 25, 2023
6 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the fix/obsolete-without-bridge-option-e2e branch September 25, 2023 15:48
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants