Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM-846 Stake manager post epoch problem #1935

Merged
merged 2 commits into from
Sep 28, 2023
Merged

EVM-846 Stake manager post epoch problem #1935

merged 2 commits into from
Sep 28, 2023

Conversation

igorcrevar
Copy link
Contributor

Description

Stake manager creates (and saves) its initial state on PostEpoch call. This could lead to a problem if save fails

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@igorcrevar igorcrevar added the bug fix Functionality that fixes a bug label Sep 26, 2023
@igorcrevar igorcrevar requested a review from a team September 26, 2023 08:18
@igorcrevar igorcrevar self-assigned this Sep 26, 2023
@igorcrevar igorcrevar force-pushed the feature/stake_manager_postepoch_bug_fix branch from f58f579 to a587bea Compare September 26, 2023 08:52
@igorcrevar igorcrevar force-pushed the feature/stake_manager_postepoch_bug_fix branch from a587bea to 174ae7f Compare September 26, 2023 09:13
@igorcrevar igorcrevar force-pushed the feature/stake_manager_postepoch_bug_fix branch from d9188be to ad50306 Compare September 28, 2023 09:31
@igorcrevar igorcrevar merged commit 02e2d47 into develop Sep 28, 2023
6 checks passed
@igorcrevar igorcrevar deleted the feature/stake_manager_postepoch_bug_fix branch September 28, 2023 10:48
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stana-miric stana-miric stana-miric approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@igorcrevar igorcrevar

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@igorcrevar @stana-miric @goran-ethernal