Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM-841-Fix TestE2E_Bridge_Transfers #1943

Merged
merged 2 commits into from
Sep 28, 2023
Merged

EVM-841-Fix TestE2E_Bridge_Transfers #1943

merged 2 commits into from
Sep 28, 2023

Conversation

Nemanja0x
Copy link
Collaborator

Description

TestE2E_Bridge_Transfers was fixed to wait a maximum (predefined) number of epochs until all the events are processed. If the number is reached, the test will fail.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Running the E2E test locally.

@Nemanja0x Nemanja0x added the bug fix Functionality that fixes a bug label Sep 28, 2023
dusan-maksimovic
dusan-maksimovic requested changes Sep 28, 2023
View reviewed changes
e2e-polybft/e2e/bridge_test.go Outdated Show resolved Hide resolved
e2e-polybft/e2e/bridge_test.go Outdated Show resolved Hide resolved
@Nemanja0x Nemanja0x merged commit 1bcf30b into develop Sep 28, 2023
7 checks passed
@Nemanja0x Nemanja0x deleted the EVM-841 branch September 28, 2023 13:46
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@igorcrevar igorcrevar igorcrevar approved these changes

@dusan-maksimovic dusan-maksimovic dusan-maksimovic approved these changes

@stana-miric stana-miric stana-miric approved these changes

Assignees
No one assigned
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Nemanja0x @igorcrevar @dusan-maksimovic @stana-miric