Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove todo comment related to retrieving the jsonrpc block #1961

Merged

Conversation

stana-miric
Copy link
Contributor

Description

It is not possible to add a function to the header type that would return a JSONRPC block object because that would result in a circular reference. Another option would be to create an additional function, such as "toBlock," that takes the header as input. However, we would still need the block itself for calculating the "Size" field. Since the "toBlock" function is straightforward, I don't see the point in doing anything about this issue.
This PR contains removes todo comment from the code

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@stana-miric stana-miric requested a review from a team October 5, 2023 10:40
@stana-miric stana-miric self-assigned this Oct 5, 2023
@Stefan-Ethernal Stefan-Ethernal merged commit 4dacf15 into develop Oct 6, 2023
7 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-524-add-get-block-function-to-header-type branch October 6, 2023 12:39
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants