Revive race detection flag and race conditions fixes in the test execution #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan-Ethernal
commented
Oct 6, 2023
jelacamarko
approved these changes
Oct 6, 2023
* Provide race and shuffle flags * Fix race condition in TestBlockchain_VerifyBlockParent test * Fix race conditions in Test_TxPool_validateTx * Capture loop variable * Fix TestAddTxsInOrder * Linter fixes * Fix TestBlockchain_VerifyBlockBody race conditions * Fix Test_VerifySignature_NegativeCases * Fix TestDropKnownGossipTx * Retrieve tx hash in a thread safe manner * Fix TestStatusPubSub race condition * Fix peers_test * Fix Test_newTracer * Provide race flag when building binary and running fuzz tests * Fix data races in fund and deposit_erc20 commands * Fix TestEventSubscription_ProcessedEvents * Fix TestSimpleGossip (hopefully) * Fix data race in e2e tests (txRelayer.SendTransactionLocal) * Avoid race conditions in ibft/signer package * Increase timeout in TestEventSubscription_ProcessedEvents * Fix TestResetAccounts_Enqueued flakiness * Remove race flags from e2e and property tests * Update command/bridge/deposit/erc20/deposit_erc20.go Co-authored-by: Victor Castell <victor@polygon.technology> * Fix transaction.Copy function --------- Co-authored-by: Victor Castell <victor@polygon.technology>
Stefan-Ethernal
force-pushed
the
EVM-854-revive-race-detection-during-testing
branch
from
7c90d54
to
de0825f
Compare
Stefan-Ethernal
had a problem deploying
to
devnet
GitHub Actions
Failure
Stefan-Ethernal
had a problem deploying
to
devnet
GitHub Actions
Failure
Stefan-Ethernal
had a problem deploying
to
devnet
GitHub Actions
Failure
Stefan-Ethernal
had a problem deploying
to
devnet
GitHub Actions
Failure
Stefan-Ethernal
force-pushed
the
EVM-854-revive-race-detection-during-testing
branch
3 times, most recently
from
68ed8b2
to
129e91a
Compare
Stefan-Ethernal
had a problem deploying
to
devnet
GitHub Actions
Failure
Stefan-Ethernal
had a problem deploying
to
devnet
GitHub Actions
Failure
Stefan-Ethernal
force-pushed
the
EVM-854-revive-race-detection-during-testing
branch
from
129e91a
to
de0825f
Compare
Nemanja0x
reviewed
Oct 6, 2023
Nemanja0x
reviewed
Oct 6, 2023
Nemanja0x
approved these changes
Oct 6, 2023
Stefan-Ethernal
deleted the
EVM-854-revive-race-detection-during-testing
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR revives #1925, but removes race detector flag when building a binary.
Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing
Manual tests
Please complete this section if you ran manual tests for this functionality, otherwise delete it
Documentation update
Please link the documentation update PR in this section if it's present, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it