Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option to specify a root path for IBFT validators dir #1986

Merged
merged 6 commits into from
Oct 18, 2023
Merged

Added option to specify a root path for IBFT validators dir #1986

merged 6 commits into from
Oct 18, 2023

Conversation

begmaroman
Copy link
Contributor

@begmaroman begmaroman commented Oct 13, 2023 •
edited

Description

Currently, the command that generates validators set does not support an option to use a specific root dir so the current one is used always.
This PR introduces a root validators path parameter.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@begmaroman begmaroman self-assigned this Oct 13, 2023
@begmaroman begmaroman added bug fix Functionality that fixes a bug feature New update to Polygon Edge labels Oct 13, 2023
@begmaroman begmaroman marked this pull request as ready for review October 13, 2023 06:06
Stefan-Ethernal
Stefan-Ethernal approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overal LGTM, tnx for fixing this. Leaving a couple of considerations though.

docker/local/polygon-edge.sh Outdated Show resolved Hide resolved
command/genesis/genesis.go Outdated Show resolved Hide resolved
command/ibft/switch/ibft_switch.go Outdated Show resolved Hide resolved
@begmaroman begmaroman merged commit b1e7a26 into develop Oct 18, 2023
9 checks passed
@begmaroman begmaroman deleted the feature/EVM-862 branch October 18, 2023 07:23
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rachit77 rachit77 rachit77 approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@stana-miric stana-miric stana-miric approved these changes

@vcastellm vcastellm Awaiting requested review from vcastellm

@igorcrevar igorcrevar Awaiting requested review from igorcrevar

@goran-ethernal goran-ethernal Awaiting requested review from goran-ethernal

Assignees

@begmaroman begmaroman

Labels
bug fix Functionality that fixes a bug feature New update to Polygon Edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@begmaroman @rachit77 @Stefan-Ethernal @stana-miric