Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

estimateGas fix for simple value transactions and contract creations #1998

Merged
merged 3 commits into from
Oct 19, 2023
Merged

estimateGas fix for simple value transactions and contract creations #1998

merged 3 commits into from
Oct 19, 2023

Conversation

goran-ethernal
Copy link
Contributor

@goran-ethernal goran-ethernal commented Oct 19, 2023 •
edited
Loading

Description

eth_estimateGas was failing on Edge for simple value transfer transactions,
Additionally, for other, non-simple transactions, it was missing a non payable flag to be passed to transition object.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@goran-ethernal goran-ethernal self-assigned this Oct 19, 2023
@goran-ethernal goran-ethernal added the bug fix Functionality that fixes a bug label Oct 19, 2023
@goran-ethernal goran-ethernal requested a review from a team October 19, 2023 10:55
@goran-ethernal goran-ethernal marked this pull request as ready for review October 19, 2023 10:55
@Stefan-Ethernal
Copy link
Contributor

Can we add another e2e test case to this test TestE2E_JsonRPC?

@goran-ethernal goran-ethernal force-pushed the estimateGas-fix branch 2 times, most recently from c59a937 to 098fffb Compare October 19, 2023 12:36
@goran-ethernal
Copy link
Contributor Author

@Stefan-Ethernal New e2e added.

@goran-ethernal goran-ethernal merged commit 5515483 into develop Oct 19, 2023
7 checks passed
@goran-ethernal goran-ethernal deleted the estimateGas-fix branch October 19, 2023 18:01
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@igorcrevar igorcrevar igorcrevar approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@dusan-maksimovic dusan-maksimovic dusan-maksimovic approved these changes

@stana-miric stana-miric stana-miric approved these changes

Assignees

@goran-ethernal goran-ethernal

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@goran-ethernal @Stefan-Ethernal @igorcrevar @dusan-maksimovic @stana-miric