Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand fallback errors in tx relayer when dynamic fee tx sending fails #2000

Conversation

Stefan-Ethernal
Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal commented Oct 19, 2023

Description

This PR adds a "method not found" error which also triggers the fallback mechanism from sending dynamic fee tx to legacy tx in tx relayer. This was due to the fact that the Besu client does not yet implement the eth_maxPriorityFeePerGas function and therefore sends dynamic fee tx when bootstrapping Supernets fails. This is a mitigation measure to try by sending legacy tx as a fallback.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

txrelayer/txrelayer.go Outdated Show resolved Hide resolved
Co-authored-by: Denis Policastro <denis.policastro@gmail.com>
@Stefan-Ethernal Stefan-Ethernal self-assigned this Oct 20, 2023
@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Oct 20, 2023
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review October 20, 2023 12:54
@Stefan-Ethernal Stefan-Ethernal requested a review from a team October 20, 2023 12:54
@Stefan-Ethernal Stefan-Ethernal changed the title Add fallback errors in tx relayer Expand fallback errors in tx relayer when dynamic fee tx sending fails Oct 20, 2023
@Stefan-Ethernal Stefan-Ethernal requested a review from a team October 20, 2023 13:08
@Stefan-Ethernal Stefan-Ethernal merged commit 38fa45b into develop Oct 23, 2023
10 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-775-check-errors-different-ethereum-clients-return-when-dynamic-fee-tx-is-sent-without-london-fork branch October 23, 2023 08:27
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
4 participants