Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add json tags for Header struct #566

Merged
merged 1 commit into from
May 31, 2022
Merged

Add json tags for Header struct #566

merged 1 commit into from
May 31, 2022

Conversation

0xAleksaOpacic
Copy link
Contributor

@0xAleksaOpacic 0xAleksaOpacic commented May 30, 2022 •
edited

Description

This PR standardizes JSON output for the Block header. In our code return values were capital letter first but needs to be camel case

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Tested with the script provided by Arcana

Additional comments

Fixes EDGE-575

@0xAleksaOpacic 0xAleksaOpacic self-assigned this May 30, 2022
@0xAleksaOpacic 0xAleksaOpacic marked this pull request as draft May 30, 2022 12:51
@0xAleksaOpacic 0xAleksaOpacic added the bug fix Functionality that fixes a bug label May 30, 2022
@0xAleksaOpacic 0xAleksaOpacic marked this pull request as ready for review May 30, 2022 14:13
zivkovicmilos
zivkovicmilos approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's baffling how we're adding this just now 🤦‍♂️

Looks good 💯

@zivkovicmilos zivkovicmilos added this to the 0.4.1 Release milestone May 30, 2022
@0xAleksaOpacic 0xAleksaOpacic merged commit cad2fb2 into develop May 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2022
@0xAleksaOpacic 0xAleksaOpacic deleted the bugfix/invalid_outputs_for_block_subscriptions branch May 31, 2022 11:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

@Kourin1996 Kourin1996 Kourin1996 approved these changes

@dbrajovic dbrajovic dbrajovic approved these changes

@lazartravica lazartravica Awaiting requested review from lazartravica

Assignees

@0xAleksaOpacic 0xAleksaOpacic

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
Release 0.4.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@0xAleksaOpacic @zivkovicmilos @Kourin1996 @dbrajovic