Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interface of IsValidCommittedSeal and InsertBlock by go-ibft's update #677

Merged
merged 4 commits into from
Aug 11, 2022

Conversation

Kourin1996
Copy link
Contributor

Description

Fix the method interfaces of IBFTBackend (IsValidCommittedSeal, InsertBlock) based on go-ibft's update (0xPolygon/go-ibft#24)

Please run go mod vendor after 0xPolygon/go-ibft#24 is merged before this PR is merged

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Kourin1996 Kourin1996 added the feature New update to Polygon Edge label Aug 9, 2022
@Kourin1996 Kourin1996 self-assigned this Aug 9, 2022
Copy link
Contributor

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

Make sure to update this branch as soon as we merge out the PR on go-ibft 🙏

@zivkovicmilos
Copy link
Contributor

@Kourin1996

Make sure to also add the CommittedSeal creation in BuildCommitMessage on the backend

@Kourin1996 Kourin1996 marked this pull request as ready for review August 10, 2022 10:34
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #677 (b44c274) into develop (b5462e0) will increase coverage by 0.05%.
The diff coverage is 45.31%.

@@             Coverage Diff             @@
##           develop     #677      +/-   ##
===========================================
+ Coverage    48.65%   48.71%   +0.05%     
===========================================
  Files          112      112              
  Lines        15364    15372       +8     
===========================================
+ Hits          7476     7488      +12     
+ Misses        7254     7252       -2     
+ Partials       634      632       -2     
Impacted Files Coverage Δ
blockchain/subscription.go 72.00% <ø> (ø)
blockchain/testing.go 59.29% <ø> (ø)
consensus/ibft/consensus.go 0.00% <ø> (ø)
consensus/ibft/consensus_backend.go 0.00% <0.00%> (ø)
consensus/ibft/ibft.go 4.00% <0.00%> (ø)
consensus/ibft/pos.go 0.00% <ø> (ø)
consensus/ibft/sign.go 64.58% <ø> (ø)
consensus/ibft/verifier.go 0.00% <0.00%> (ø)
contracts/staking/query.go 71.42% <ø> (ø)
jsonrpc/errors.go 41.66% <ø> (ø)
... and 24 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Kourin1996 Kourin1996 merged commit fb219ba into develop Aug 11, 2022
@Kourin1996 Kourin1996 deleted the feature/update-go-ibft-for-#24 branch August 11, 2022 08:12
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants