[TxPool] Introduce limit on enqueued transactions #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrajovic
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #687 +/- ##
===========================================
- Coverage 48.77% 48.61% -0.16%
===========================================
Files 112 112
Lines 15382 15390 +8
===========================================
- Hits 7502 7482 -20
- Misses 7249 7274 +25
- Partials 631 634 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dbrajovic
added
bug fix
dbrajovic
requested review from
zivkovicmilos,
lazartravica,
Kourin1996 and
Aleksao998
as code owners
zivkovicmilos
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
Looks great 💯
Tested this out with Pandora's box, works like a charm 👏
Aleksao998
approved these changes
Aug 22, 2022
Kourin1996
approved these changes
Aug 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a configurable limit on the amount of transactions any account in the TxPool can hold at any given time.
--max-enqueued [DEFAULT= 128]As the
enqueuedpart of an account just represents future transactions (higher nonce than expected), there are no particular benefits to keeping a large number of them in this queue as much as there are vulnerability risks that all result in an eventually bricked pool full of enqueued transactions.The limit also enforces a rate limiting on transaction acquisition for any account - in effect, an incoming transaction would be rejected if there is no space for it in its respective
enqueuedqueue. What this means is that aggressive spams are greatly mitigated, delaying the point of pool overflow.Changes include
Checklist
Testing
Documentation update
Please link the documentation update PR in this section if it's present, otherwise delete it
Additional comments
Fixes EDGE-732