-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TxPool] Reject future transactions during high memory usage #690
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #690 +/- ##
===========================================
+ Coverage 48.72% 48.75% +0.03%
===========================================
Files 112 112
Lines 15432 15437 +5
===========================================
+ Hits 7519 7527 +8
+ Misses 7279 7277 -2
+ Partials 634 633 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested with SportX script on local everything works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment
Description
This PR adds an additional constraint on transaction acquisition during periods of high slots usage.
If a transaction sent to the pool is not expected in terms of nonce (meaning it's a future transactions or spam) then it is rejected.
Changes include
Checklist
Testing
Additional comments
Fixes EDGE-732