Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve high CPU loads for non-validators #691

Merged
merged 4 commits into from
Aug 25, 2022

Conversation

dbrajovic
Copy link
Contributor

@dbrajovic dbrajovic commented Aug 18, 2022

Description

This PR resolves the high CPU load issues for non-validator nodes.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Additional comments

Fixes EDGE-744

@zivkovicmilos zivkovicmilos changed the title write fix Resolve high CPU loads for non-validators Aug 18, 2022
@zivkovicmilos zivkovicmilos added the hotfix Major bug fix that should be merged ASAP label Aug 18, 2022
@zivkovicmilos zivkovicmilos linked an issue Aug 18, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #691 (5800823) into develop (de62840) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #691      +/-   ##
===========================================
- Coverage    48.77%   48.59%   -0.18%     
===========================================
  Files          112      112              
  Lines        15382    15385       +3     
===========================================
- Hits          7502     7477      -25     
- Misses        7249     7274      +25     
- Partials       631      634       +3     
Impacted Files Coverage Δ
consensus/ibft/consensus_backend.go 0.00% <0.00%> (ø)
consensus/ibft/ibft.go 3.93% <0.00%> (-0.07%) ⬇️
network/server_discovery.go 73.88% <0.00%> (-15.93%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Aleksao998 Aleksao998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ZeljkoBenovic ZeljkoBenovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on an existing cluster.
The CPU utilization is now way less than on the validator nodes.

Great job 🥇

@zivkovicmilos zivkovicmilos added this to the 0.6 Release milestone Aug 24, 2022
@dbrajovic dbrajovic merged commit 869742f into develop Aug 25, 2022
@dbrajovic dbrajovic deleted the fix/non-validator-cpu-load branch August 25, 2022 10:02
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotfix Major bug fix that should be merged ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cpu load very high
4 participants