Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter errors #697

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Fix linter errors #697

merged 2 commits into from
Aug 26, 2022

Conversation

Aleksao998
Copy link
Contributor

@Aleksao998 Aleksao998 commented Aug 26, 2022

Description

This PR fixes latest linter errors

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Aleksao998 Aleksao998 self-assigned this Aug 26, 2022
@Aleksao998 Aleksao998 added the bug fix Functionality that fixes a bug label Aug 26, 2022
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #697 (f3777f3) into develop (de62840) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #697      +/-   ##
===========================================
- Coverage    48.77%   48.59%   -0.18%     
===========================================
  Files          112      112              
  Lines        15382    15385       +3     
===========================================
- Hits          7502     7477      -25     
- Misses        7249     7274      +25     
- Partials       631      634       +3     
Impacted Files Coverage Δ
consensus/ibft/consensus_backend.go 0.00% <0.00%> (ø)
consensus/ibft/ibft.go 3.93% <0.00%> (-0.07%) ⬇️
network/server_discovery.go 73.88% <0.00%> (-15.93%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Aleksao998 Aleksao998 merged commit 7e4c3d7 into develop Aug 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2022
@Aleksao998 Aleksao998 deleted the fix/linter_errors branch September 16, 2022 10:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants