Fix zero from field in Tx

[Kourin1996]

Fix EDGE-787

Description

This PR fixes the issue that from field in the transaction data JSON-RPC API returns is zero address in the latest code. The issue is caused by that block data is unmarshalled before writing block in latest IBFT and this encoding doesn't add from field in the marshaled data.

This PR adds 2 fixes:
(1) Recover from field in transaction in blockchain module before writing the block into storage.
(2) Recover from field if the transaction in the block doesn't have from field when fetching block from storage and update the data in storage as well.

Relevant issue:
#684

Changes include

• Bugfix (non-breaking change that solves an issue)
• Hotfix (change that solves an urgent issue, and requires immediate attention)
• New feature (non-breaking change that adds functionality)
• Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

• I have assigned this PR to myself
• I have added at least 1 reviewer
• I have added the relevant labels
• I have updated the official documentation
• I have added sufficient documentation in code

Testing

• I have tested this code with the official test suite
• I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

[zivkovicmilos]

Looks great 💯

I would just like to note that this issue was present even before we upgraded our consensus layer - the previous IBFT implementation (incorrectly) had a side effect of instantiating the From field of a transaction when verifying a block (even though it was not set), something that no normal consensus implementation should do. The new IBFT implementation doesn't do any such shenanigans, so this error propagated out (the transaction From not being marshaled in RLP) to other parts of the system.

Just make sure to resolve the linting errors.

Thank you for fixing this 🙏

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (release/0.5.1@68df30d). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release/0.5.1     #719   +/-   ##
================================================
  Coverage                 ?   52.56%           
================================================
  Files                    ?      130           
  Lines                    ?    17108           
  Branches                 ?        0           
================================================
  Hits                     ?     8993           
  Misses                   ?     7470           
  Partials                 ?      645           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[Aleksao998]

LGTM

[zivkovicmilos]

Looks good again 💯