Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Memory fix] Remove memory leak in event subscriptions #741

Merged
merged 2 commits into from
Sep 21, 2022

Conversation

zivkovicmilos
Copy link
Contributor

@zivkovicmilos zivkovicmilos commented Sep 19, 2022

Description

This PR removes the memory leak present in the blockchain event subscriptions.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Tested this out with the monitor command.

Additional comments

Fixes EDGE-849

@zivkovicmilos zivkovicmilos added the hotfix Major bug fix that should be merged ASAP label Sep 19, 2022
@zivkovicmilos zivkovicmilos self-assigned this Sep 19, 2022
@zivkovicmilos zivkovicmilos linked an issue Sep 19, 2022 that may be closed by this pull request
@zivkovicmilos zivkovicmilos changed the title [Memory fix] Remove dangling pointers in the subscription struct [Memory fix] Remove memory leak in event subscriptions Sep 19, 2022
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release/0.5.1@68df30d). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release/0.5.1     #741   +/-   ##
================================================
  Coverage                 ?   48.83%           
================================================
  Files                    ?      112           
  Lines                    ?    15442           
  Branches                 ?        0           
================================================
  Hits                     ?     7541           
  Misses                   ?     7267           
  Partials                 ?      634           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@0xAleksaOpacic 0xAleksaOpacic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zivkovicmilos zivkovicmilos merged commit 52b6261 into release/0.5.1 Sep 21, 2022
@zivkovicmilos zivkovicmilos deleted the hotfix/memory-leak branch September 21, 2022 09:01
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotfix Major bug fix that should be merged ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Steady memory creep
3 participants