-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup inactive transactions in non-validator #742
Cleanup inactive transactions in non-validator #742
Conversation
Codecov Report
@@ Coverage Diff @@
## release/0.5.1 #742 +/- ##
================================================
Coverage ? 49.05%
================================================
Files ? 112
Lines ? 15529
Branches ? 0
================================================
Hits ? 7618
Misses ? 7274
Partials ? 637 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…remove it in the next minor release
…ansactions in non-validator's TxPool
f25e2c4
to
78a3e07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already looks good, just need to resolve the updateUnadoptedCounts
detail 👍
Fix EDGE-843
Description
This PR adds a function to remove the transactions that have not been adopted for a certain number of transactions.
And also this PR disable
--seal
flag but keep CLI flag because this PR is intended to be merged in the next PATCH releaseRelevant: #731
Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing
Manual tests
Documentation update
Please link the documentation update PR in this section if it's present, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it