Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce local development cluster script #912

Merged
merged 6 commits into from
Nov 16, 2022

Conversation

vcastellm
Copy link
Contributor

Description

Introduce local development cluster script

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Run the cluster

@vcastellm vcastellm added the feature New update to Polygon Edge label Nov 15, 2022
@vcastellm vcastellm self-assigned this Nov 15, 2022
scripts/cluster Outdated Show resolved Hide resolved
scripts/cluster Outdated Show resolved Hide resolved
scripts/cluster Outdated Show resolved Hide resolved
scripts/cluster Outdated Show resolved Hide resolved
Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #912 (7fd804c) into feature/v3-parity (455f185) will increase coverage by 2.09%.
The diff coverage is n/a.

❗ Current head 7fd804c differs from pull request most recent head c60e6b2. Consider uploading reports for the commit c60e6b2 to get more accurate results

@@                  Coverage Diff                  @@
##           feature/v3-parity     #912      +/-   ##
=====================================================
+ Coverage              51.76%   53.85%   +2.09%     
=====================================================
  Files                    162      162              
  Lines                  21597    21676      +79     
=====================================================
+ Hits                   11180    11674     +494     
+ Misses                  9508     9045     -463     
- Partials                 909      957      +48     
Impacted Files Coverage Δ
jsonrpc/types.go 75.83% <0.00%> (-1.67%) ⬇️
jsonrpc/eth_endpoint.go 69.55% <0.00%> (-0.44%) ⬇️
jsonrpc/filter_manager.go 77.17% <0.00%> (-0.23%) ⬇️
consensus/polybft/blockchain_wrapper.go 8.97% <0.00%> (+2.56%) ⬆️
consensus/polybft/consensus_runtime.go 54.07% <0.00%> (+2.79%) ⬆️
consensus/polybft/state.go 73.13% <0.00%> (+3.83%) ⬆️
consensus/polybft/validator_metadata.go 80.76% <0.00%> (+3.84%) ⬆️
consensus/polybft/extra.go 86.64% <0.00%> (+3.90%) ⬆️
consensus/polybft/state_transaction.go 62.60% <0.00%> (+4.81%) ⬆️
types/types.go 61.81% <0.00%> (+7.27%) ⬆️
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vcastellm vcastellm merged commit 8627f12 into feature/v3-parity Nov 16, 2022
@vcastellm vcastellm deleted the feature/local-cluster branch November 16, 2022 15:14
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants