Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM-220 TestClusterBlockSync/BLS fails in voting power branch #926

Merged
merged 1 commit into from Nov 28, 2022

Conversation

igorcrevar
Copy link
Contributor

@igorcrevar igorcrevar commented Nov 17, 2022

Description

go.mod must be updated to the latest go-ibft commit introduced with 0xPolygon/go-ibft#48
HasQuorum methods must properly handle protoIBFT.MessageType_PREPREPARE and protoIBFT.MessageType_PREPARE cases

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@igorcrevar igorcrevar added the don't merge Please don't merge this functionality temporarily label Nov 17, 2022
@igorcrevar igorcrevar marked this pull request as ready for review November 17, 2022 15:12
@igorcrevar igorcrevar removed the don't merge Please don't merge this functionality temporarily label Nov 17, 2022
@igorcrevar igorcrevar marked this pull request as draft November 17, 2022 15:20
@igorcrevar igorcrevar force-pushed the e2e_bls_test_failing_test_branch branch 2 times, most recently from 64fea1b to b4dc753 Compare November 17, 2022 16:24
@igorcrevar igorcrevar changed the base branch from develop to feature/v3-parity November 17, 2022 16:38
@igorcrevar igorcrevar marked this pull request as ready for review November 17, 2022 17:20
@igorcrevar igorcrevar marked this pull request as draft November 17, 2022 17:20
@igorcrevar igorcrevar added bug fix Functionality that fixes a bug and removed bug fix Functionality that fixes a bug labels Nov 18, 2022
@igorcrevar igorcrevar self-assigned this Nov 18, 2022
@0xSasaPrsic 0xSasaPrsic changed the base branch from feature/v3-parity to feature/polybft-voting-power November 18, 2022 09:24
@0xSasaPrsic 0xSasaPrsic changed the base branch from feature/polybft-voting-power to feature/v3-parity November 18, 2022 09:24
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #926 (70b1b36) into feature/v3-parity (64f728a) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@                  Coverage Diff                  @@
##           feature/v3-parity     #926      +/-   ##
=====================================================
- Coverage              53.99%   53.97%   -0.03%     
=====================================================
  Files                    163      163              
  Lines                  21576    21584       +8     
=====================================================
  Hits                   11649    11649              
- Misses                  8985     8993       +8     
  Partials                 942      942              
Impacted Files Coverage Δ
consensus/ibft/consensus_backend.go 0.00% <0.00%> (ø)
consensus/polybft/consensus_runtime.go 53.80% <0.00%> (-0.27%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@igorcrevar igorcrevar force-pushed the e2e_bls_test_failing_test_branch branch 5 times, most recently from 036c8ad to 4259919 Compare November 21, 2022 09:25
@igorcrevar igorcrevar changed the base branch from feature/v3-parity to develop November 21, 2022 09:26
@igorcrevar igorcrevar force-pushed the e2e_bls_test_failing_test_branch branch 4 times, most recently from 095c895 to c4be9c5 Compare November 24, 2022 08:36
@igorcrevar igorcrevar changed the base branch from develop to feature/v3-parity November 24, 2022 08:36
@igorcrevar igorcrevar force-pushed the e2e_bls_test_failing_test_branch branch 3 times, most recently from 1992479 to fa25da9 Compare November 24, 2022 09:41
@igorcrevar igorcrevar force-pushed the e2e_bls_test_failing_test_branch branch 3 times, most recently from 2a37cd3 to 0250d92 Compare November 25, 2022 13:22
@igorcrevar igorcrevar changed the title TestClusterBlockSync BLS e2e test failing EVM-220 TestClusterBlockSync/BLS fails in voting power branch Nov 25, 2022
@igorcrevar igorcrevar added the bug fix Functionality that fixes a bug label Nov 25, 2022
@igorcrevar igorcrevar force-pushed the e2e_bls_test_failing_test_branch branch from 0250d92 to e73a11d Compare November 25, 2022 15:32
@igorcrevar igorcrevar merged commit e7ff3f3 into feature/v3-parity Nov 28, 2022
@igorcrevar igorcrevar deleted the e2e_bls_test_failing_test_branch branch November 28, 2022 10:17
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants