-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVM-220 TestClusterBlockSync/BLS fails in voting power branch #926
Merged
igorcrevar
merged 1 commit into
feature/v3-parity
from
e2e_bls_test_failing_test_branch
Nov 28, 2022
Merged
EVM-220 TestClusterBlockSync/BLS fails in voting power branch #926
igorcrevar
merged 1 commit into
feature/v3-parity
from
e2e_bls_test_failing_test_branch
Nov 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorcrevar
added
the
don't merge
Please don't merge this functionality temporarily
label
Nov 17, 2022
igorcrevar
removed
the
don't merge
Please don't merge this functionality temporarily
label
Nov 17, 2022
igorcrevar
force-pushed
the
e2e_bls_test_failing_test_branch
branch
2 times, most recently
from
November 17, 2022 16:24
64fea1b
to
b4dc753
Compare
igorcrevar
added
bug fix
Functionality that fixes a bug
and removed
bug fix
Functionality that fixes a bug
labels
Nov 18, 2022
0xSasaPrsic
changed the base branch from
feature/v3-parity
to
feature/polybft-voting-power
November 18, 2022 09:24
0xSasaPrsic
changed the base branch from
feature/polybft-voting-power
to
feature/v3-parity
November 18, 2022 09:24
Codecov Report
@@ Coverage Diff @@
## feature/v3-parity #926 +/- ##
=====================================================
- Coverage 53.99% 53.97% -0.03%
=====================================================
Files 163 163
Lines 21576 21584 +8
=====================================================
Hits 11649 11649
- Misses 8985 8993 +8
Partials 942 942
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
igorcrevar
force-pushed
the
e2e_bls_test_failing_test_branch
branch
5 times, most recently
from
November 21, 2022 09:25
036c8ad
to
4259919
Compare
igorcrevar
force-pushed
the
e2e_bls_test_failing_test_branch
branch
4 times, most recently
from
November 24, 2022 08:36
095c895
to
c4be9c5
Compare
igorcrevar
force-pushed
the
e2e_bls_test_failing_test_branch
branch
3 times, most recently
from
November 24, 2022 09:41
1992479
to
fa25da9
Compare
igorcrevar
force-pushed
the
e2e_bls_test_failing_test_branch
branch
3 times, most recently
from
November 25, 2022 13:22
2a37cd3
to
0250d92
Compare
igorcrevar
changed the title
TestClusterBlockSync BLS e2e test failing
EVM-220 TestClusterBlockSync/BLS fails in voting power branch
Nov 25, 2022
igorcrevar
force-pushed
the
e2e_bls_test_failing_test_branch
branch
from
November 25, 2022 15:32
0250d92
to
e73a11d
Compare
igorcrevar
force-pushed
the
e2e_bls_test_failing_test_branch
branch
from
November 28, 2022 09:27
e73a11d
to
70b1b36
Compare
igorcrevar
requested review from
vcastellm,
lazartravica,
JekaMas,
trimixlover,
goran-ethernal,
ferranbt and
Nemanja0x
November 28, 2022 09:35
Nemanja0x
approved these changes
Nov 28, 2022
goran-ethernal
approved these changes
Nov 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
go.mod
must be updated to the latestgo-ibft
commit introduced with 0xPolygon/go-ibft#48HasQuorum
methods must properly handleprotoIBFT.MessageType_PREPREPARE
andprotoIBFT.MessageType_PREPARE
casesChanges include
Checklist
Testing