-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track updates for validators #939
Merged
Stefan-Ethernal
merged 3 commits into
feature/v3-parity
from
feature/EVM-207-update-voting-power-for-validators
Nov 23, 2022
Merged
Track updates for validators #939
Stefan-Ethernal
merged 3 commits into
feature/v3-parity
from
feature/EVM-207-update-voting-power-for-validators
Nov 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan-Ethernal
force-pushed
the
feature/EVM-207-update-voting-power-for-validators
branch
from
November 21, 2022 10:01
cab12ed
to
90d2e74
Compare
Expand ValidatorSetDelta
Stefan-Ethernal
force-pushed
the
feature/EVM-207-update-voting-power-for-validators
branch
from
November 21, 2022 10:48
90d2e74
to
7172ddf
Compare
Codecov Report
@@ Coverage Diff @@
## feature/v3-parity #939 +/- ##
=====================================================
+ Coverage 53.84% 53.99% +0.14%
=====================================================
Files 163 163
Lines 21566 21586 +20
=====================================================
+ Hits 11613 11656 +43
+ Misses 9007 8989 -18
+ Partials 946 941 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Stefan-Ethernal
force-pushed
the
feature/EVM-207-update-voting-power-for-validators
branch
from
November 22, 2022 08:25
40f46a1
to
293b050
Compare
Stefan-Ethernal
requested review from
Nemanja0x,
b00ris,
ferranbt,
goran-ethernal,
JekaMas and
vcastellm
November 22, 2022 08:56
igorcrevar
approved these changes
Nov 22, 2022
b00ris
approved these changes
Nov 23, 2022
goran-ethernal
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a short comment, but in general looks good.
Stefan-Ethernal
deleted the
feature/EVM-207-update-voting-power-for-validators
branch
November 23, 2022 15:43
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces another field to the
ValidatorSetDelta
which allows us to track updates inValidatorMetadata
instances.Changes include
Checklist
Testing