Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track updates for validators #939

Conversation

Stefan-Ethernal
Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal commented Nov 20, 2022

Description

This PR introduces another field to the ValidatorSetDelta which allows us to track updates in ValidatorMetadata instances.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal self-assigned this Nov 20, 2022
@Stefan-Ethernal Stefan-Ethernal force-pushed the feature/EVM-207-update-voting-power-for-validators branch from cab12ed to 90d2e74 Compare November 21, 2022 10:01
@Stefan-Ethernal Stefan-Ethernal force-pushed the feature/EVM-207-update-voting-power-for-validators branch from 90d2e74 to 7172ddf Compare November 21, 2022 10:48
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #939 (293b050) into feature/v3-parity (db63825) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@                  Coverage Diff                  @@
##           feature/v3-parity     #939      +/-   ##
=====================================================
+ Coverage              53.84%   53.99%   +0.14%     
=====================================================
  Files                    163      163              
  Lines                  21566    21586      +20     
=====================================================
+ Hits                   11613    11656      +43     
+ Misses                  9007     8989      -18     
+ Partials                 946      941       -5     
Impacted Files Coverage Δ
consensus/polybft/extra.go 86.98% <100.00%> (+0.33%) ⬆️
consensus/polybft/validator_metadata.go 85.71% <100.00%> (+4.94%) ⬆️
network/server_discovery.go 85.09% <0.00%> (+10.55%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Stefan-Ethernal Stefan-Ethernal added the feature New update to Polygon Edge label Nov 21, 2022
@Stefan-Ethernal Stefan-Ethernal force-pushed the feature/EVM-207-update-voting-power-for-validators branch from 40f46a1 to 293b050 Compare November 22, 2022 08:25
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review November 22, 2022 08:56
Copy link
Contributor

@goran-ethernal goran-ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a short comment, but in general looks good.

@Stefan-Ethernal Stefan-Ethernal merged commit 64f728a into feature/v3-parity Nov 23, 2022
@Stefan-Ethernal Stefan-Ethernal deleted the feature/EVM-207-update-voting-power-for-validators branch November 23, 2022 15:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants