Remove State Sync execution step #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcastellm
requested review from
Stefan-Ethernal,
Nemanja0x,
igorcrevar,
b00ris,
ferranbt and
goran-ethernal
goran-ethernal
approved these changes
Nov 28, 2022
This was referenced Nov 28, 2022
lazartravica
approved these changes
Nov 28, 2022
b00ris
approved these changes
Nov 29, 2022
Stefan-Ethernal
approved these changes
Nov 29, 2022
* Add the RPC endpoint to obtain StateSync Proofs * Rootchain data to gitignore * Return the state sync along with proof * Better params for cluster script * E2E test executing state syncs * Fix tests that rely on bundle execution * Remove commitment execution related stuff
Codecov Report
@@ Coverage Diff @@
## feature/v3-parity #964 +/- ##
=====================================================
+ Coverage 53.92% 55.28% +1.36%
=====================================================
Files 163 167 +4
Lines 21556 22365 +809
=====================================================
+ Hits 11623 12365 +742
- Misses 8989 9022 +33
- Partials 944 978 +34
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vcastellm
deleted the
EVM-215-remove-the-state-sync-execution-stage-in-polybft
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not execute State Syncs internally from the client
Changes include
Breaking changes
E2E tests are not expected to pass until merging sub-sequent PRs
Checklist
Testing