Replace BLS library with github.com/kilic/bn254 #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorcrevar
requested review from
b00ris,
ferranbt,
Nemanja0x,
Stefan-Ethernal and
goran-ethernal
igorcrevar
force-pushed
the
kilic-bn254
branch
3 times, most recently
from
ddba74f
to
7d139ca
Compare
igorcrevar
force-pushed
the
kilic-bn254
branch
from
7d139ca
to
de8e9e6
Compare
Codecov Report
@@ Coverage Diff @@
## feature/v3-parity #978 +/- ##
====================================================
Coverage ? 55.28%
====================================================
Files ? 167
Lines ? 22357
Branches ? 0
====================================================
Hits ? 12361
Misses ? 9019
Partials ? 977 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
goran-ethernal
approved these changes
Nov 29, 2022
b00ris
approved these changes
Nov 29, 2022
JekaMas
reviewed
Nov 29, 2022
| g2 = new(bn256.G2).Set(&zeroG2) | ||
| } else { | ||
| g2 = new(bn256.G2).Set(p.p) | ||
| func (p *PublicKey) aggregate(next *PublicKey) *PublicKey { |
There was a problem hiding this comment.
As a separate task could we remove this code duplication(publicKey, signature)?
There was a problem hiding this comment.
At first glance it seemed like it can be unified into a single implementation, but eventually it cannot. The reason is because signature aggregation works with G1 point, whereas public key aggregates G2 points.
JekaMas
approved these changes
Nov 29, 2022
Stefan-Ethernal
approved these changes
Nov 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace BLS library with github.com/kilic/bn254
Changes include
Checklist
Testing