calldata better

contracts/PolygonZkEVM.sol

@@ -407,7 +407,7 @@ contract PolygonZkEVM is OwnableUpgradeable, EmergencyManager {
      * @param batches Struct array which the necessary data to append new batces ot the sequence
      */
     function sequenceBatches(
-        BatchData[] memory batches
+        BatchData[] calldata batches
     ) external ifNotEmergencyState onlyTrustedSequencer {
         uint256 batchesNum = batches.length;
         require(
@@ -914,11 +914,14 @@ contract PolygonZkEVM is OwnableUpgradeable, EmergencyManager {
     /**
      * @notice Allows a sequencer/user to force a batch of L2 transactions.
      * This should be used only in extreme cases where the trusted sequencer does not work as expected
+     * Note The sequencer has certain degree of control on how non-forced and forced batches are ordered
+     * In order to assure that users force transactions will be processed properly, user must not sign any other transaction
+     * with the same nonce
      * @param transactions L2 ethereum transactions EIP-155 or pre-EIP-155 with signature:
      * @param maticAmount Max amount of MATIC tokens that the sender is willing to pay
      */
     function forceBatch(
-        bytes memory transactions,
+        bytes calldata transactions,
         uint256 maticAmount
     ) external ifNotEmergencyState isForceBatchAllowed {
         // Calculate matic collateral
@@ -970,7 +973,7 @@ contract PolygonZkEVM is OwnableUpgradeable, EmergencyManager {
      * @param batches Struct array which the necessary data to append new batces ot the sequence
      */
     function sequenceForceBatches(
-        ForcedBatchData[] memory batches
+        ForcedBatchData[] calldata batches
     ) external ifNotEmergencyState isForceBatchAllowed {
         uint256 batchesNum = batches.length;
 

contracts/PolygonZkEVMBridge.sol

@@ -223,7 +223,7 @@ contract PolygonZkEVMBridge is
     function bridgeMessage(
         uint32 destinationNetwork,
         address destinationAddress,
-        bytes memory metadata
+        bytes calldata metadata
     ) external payable ifNotEmergencyState {
         require(
             destinationNetwork != networkID,
@@ -280,7 +280,7 @@ contract PolygonZkEVMBridge is
         uint32 destinationNetwork,
         address destinationAddress,
         uint256 amount,
-        bytes memory metadata
+        bytes calldata metadata
     ) external ifNotEmergencyState {
         // Verify leaf exist and it does not have been claimed
         _verifyLeaf(
@@ -394,7 +394,7 @@ contract PolygonZkEVMBridge is
         uint32 destinationNetwork,
         address destinationAddress,
         uint256 amount,
-        bytes memory metadata
+        bytes calldata metadata
     ) external ifNotEmergencyState {
         // Verify leaf exist and it does not have been claimed
         _verifyLeaf(
@@ -445,7 +445,7 @@ contract PolygonZkEVMBridge is
         string calldata name,
         string calldata symbol,
         uint8 decimals
-    ) public view returns (address) {
+    ) external view returns (address) {
         bytes32 salt = keccak256(
             abi.encodePacked(originNetwork, originTokenAddress)
         );
@@ -476,7 +476,7 @@ contract PolygonZkEVMBridge is
     function getTokenWrappedAddress(
         uint32 originNetwork,
         address originTokenAddress
-    ) public view returns (address) {
+    ) external view returns (address) {
         return
             tokenInfoToWrappedToken[
                 keccak256(abi.encodePacked(originNetwork, originTokenAddress))
@@ -523,7 +523,7 @@ contract PolygonZkEVMBridge is
         uint32 destinationNetwork,
         address destinationAddress,
         uint256 amount,
-        bytes memory metadata,
+        bytes calldata metadata,
         uint8 leafType
     ) internal {
         // Set and check nullifier
@@ -577,7 +577,7 @@ contract PolygonZkEVMBridge is
      * @notice Function to check if an index is claimed or not
      * @param index Index
      */
-    function isClaimed(uint256 index) public view returns (bool) {
+    function isClaimed(uint256 index) external view returns (bool) {
         (uint256 wordPos, uint256 bitPos) = _bitmapPositions(index);
         uint256 mask = (1 << bitPos);
         return (claimedBitMap[wordPos] & mask) == mask;

contracts/interfaces/IPolygonZkEVMBridge.sol

@@ -14,11 +14,11 @@ interface IPolygonZkEVMBridge {
     function bridgeMessage(
         uint32 destinationNetwork,
         address destinationAddress,
-        bytes memory metadata
+        bytes calldata metadata
     ) external payable;
 
     function claimAsset(
-        bytes32[32] memory smtProof,
+        bytes32[32] calldata smtProof,
         uint32 index,
         bytes32 mainnetExitRoot,
         bytes32 rollupExitRoot,
@@ -27,11 +27,11 @@ interface IPolygonZkEVMBridge {
         uint32 destinationNetwork,
         address destinationAddress,
         uint256 amount,
-        bytes memory metadata
+        bytes calldata metadata
     ) external;
 
     function claimMessage(
-        bytes32[32] memory smtProof,
+        bytes32[32] calldata smtProof,
         uint32 index,
         bytes32 mainnetExitRoot,
         bytes32 rollupExitRoot,
@@ -40,7 +40,7 @@ interface IPolygonZkEVMBridge {
         uint32 destinationNetwork,
         address destinationAddress,
         uint256 amount,
-        bytes memory metadata
+        bytes calldata metadata
     ) external;
 
     function activateEmergencyState() external;

docs/PolygonZkEVM.md

@@ -191,6 +191,9 @@ The batch fee will not be updated when the trusted aggregator verify batches
 ```
 Allows a sequencer/user to force a batch of L2 transactions.
 This should be used only in extreme cases where the trusted sequencer does not work as expected
+Note The sequencer has certain degree of control on how non-forced and forced batches are ordered
+In order to assure that users force transactions will be processed properly, user must not sign any other transaction
+with the same nonce
 
 
 #### Parameters:

docs/PolygonZkEVMBridge.md

@@ -132,7 +132,7 @@ Verify merkle proof and execute message
     string name,
     string symbol,
     uint8 decimals
-  ) public returns (address)
+  ) external returns (address)
 ```
 Returns the precalculated address of a wrapper using the token information
 
@@ -151,7 +151,7 @@ Returns the precalculated address of a wrapper using the token information
   function getTokenWrappedAddress(
     uint32 originNetwork,
     address originTokenAddress
-  ) public returns (address)
+  ) external returns (address)
 ```
 Returns the address of a wrapper using the token information if already exist
 
@@ -220,7 +220,7 @@ Verify leaf and checks that it has not been claimed
 ```solidity
   function isClaimed(
     uint256 index
-  ) public returns (bool)
+  ) external returns (bool)
 ```
 Function to check if an index is claimed or not