Feature/#1579 migrations index #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaubennassar
requested changes
Jan 31, 2023
cmd/run.go
Outdated
| @@ -311,7 +311,7 @@ func startMetricsHttpServer(c *config.Config) { | |||
| return | |||
| } | |||
| mux.Handle(metrics.Endpoint, promhttp.Handler()) | |||
| metricsServer := &http.Server{ | |||
| metricsServer := &http.Server{ // nolint | |||
There was a problem hiding this comment.
Comments that are used for compilation, linting, ... (anything done by a machine) shouldn't have a space
Suggested change
| metricsServer := &http.Server{ // nolint | |
| metricsServer := &http.Server{ //nolint |
Probably you can remove it all together and the linter will pass
cool-develope
approved these changes
Feb 1, 2023
arnaubennassar
approved these changes
Feb 1, 2023
ARR552
added a commit
that referenced
this pull request
Feb 7, 2023
* Feature/#1579 migrations index (#1612) * migration test + indexes * linter * 0006 * bug fixed * linter * suggestion + comment * handle fork id * new errors * 1 as default fork id * 1 as default fork id * add default fork id parameter * add default fork id parameter * Update prover image * update prover image --------- Co-authored-by: ToniRamirezM <toni@iden3.com>
tclemos
pushed a commit
that referenced
this pull request
Feb 14, 2023
* Feature/#1579 migrations index (#1612) * migration test + indexes * linter * 0006 * bug fixed * linter * suggestion + comment * handle fork id * new errors * 1 as default fork id * 1 as default fork id * add default fork id parameter * add default fork id parameter * Update prover image * update prover image --------- Co-authored-by: ToniRamirezM <toni@iden3.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add indexes and migration tests in release branch.
Reviewers
Main reviewers: