-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test/forced batches vectors #2093
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove claim txs * fix tests * fix tests * fix tests * remove deposit_count * fix query * fix query --------- Co-authored-by: Thiago Lemos <thiago@polygon.technology>
Signed-off-by: Nikolay Nedkov <nikolai_nedkov@yahoo.com>
Psykepro
force-pushed
the
test/forced-batches-vectors
branch
6 times, most recently
from
May 10, 2023 16:37
a1aebf4
to
b8c4f7f
Compare
agnusmor
approved these changes
May 10, 2023
Psykepro
force-pushed
the
test/forced-batches-vectors
branch
4 times, most recently
from
May 11, 2023 08:00
eace0ad
to
6b8f1ba
Compare
Psykepro
force-pushed
the
test/forced-batches-vectors
branch
2 times, most recently
from
May 11, 2023 08:18
ae2de8e
to
825b53f
Compare
…d updating e2e forced batch test to have 1 forced tx. Signed-off-by: Nikolay Nedkov <nikolai_nedkov@yahoo.com>
Psykepro
force-pushed
the
test/forced-batches-vectors
branch
from
May 11, 2023 08:44
825b53f
to
09f8571
Compare
ToniRamirezM
approved these changes
May 11, 2023
ARR552
approved these changes
May 11, 2023
Comment on lines
+268
to
+273
/* | ||
func uint32ToBool(value uint32) bool { | ||
return value != 0 | ||
} | ||
*/ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should remove this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will in next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2025. Closes #2059
What does this PR do?
Changing the
Sequencer
's implementation to:For tests:
Reviewers
Main reviewers:
Codeowner reviewers: