Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/forced batches vectors #2093

Merged
merged 9 commits into from
May 11, 2023
Merged

Test/forced batches vectors #2093

merged 9 commits into from
May 11, 2023

Conversation

Psykepro
Copy link
Contributor

Closes #2025. Closes #2059

What does this PR do?

Changing the Sequencer's implementation to:

  • have response handling of each tx
  • store successfully processed transactions.

For tests:

  • adding forced batches vector test
  • updating existing e2e forced batch test to send 1 tx in the forced batch

Reviewers

Main reviewers:

Codeowner reviewers:

Psykepro and others added 8 commits April 27, 2023 16:49
Signed-off-by: Nikolay Nedkov <nikolai_nedkov@yahoo.com>
Signed-off-by: Nikolay Nedkov <nikolai_nedkov@yahoo.com>
Signed-off-by: Nikolay Nedkov <nikolai_nedkov@yahoo.com>
* remove claim txs

* fix tests

* fix tests

* fix tests

* remove deposit_count

* fix query

* fix query

---------

Co-authored-by: Thiago Lemos <thiago@polygon.technology>
Signed-off-by: Nikolay Nedkov <nikolai_nedkov@yahoo.com>
Signed-off-by: Nikolay Nedkov <nikolai_nedkov@yahoo.com>
@Psykepro Psykepro self-assigned this May 10, 2023
@Psykepro Psykepro requested a review from tclemos as a code owner May 10, 2023 15:11
@cla-bot cla-bot bot added the cla-signed label May 10, 2023
@Psykepro Psykepro force-pushed the test/forced-batches-vectors branch 6 times, most recently from a1aebf4 to b8c4f7f Compare May 10, 2023 16:37
@agnusmor agnusmor added this to the Release 0.1.0 milestone May 10, 2023
@Psykepro Psykepro force-pushed the test/forced-batches-vectors branch 4 times, most recently from eace0ad to 6b8f1ba Compare May 11, 2023 08:00
@Psykepro Psykepro force-pushed the test/forced-batches-vectors branch 2 times, most recently from ae2de8e to 825b53f Compare May 11, 2023 08:18
…d updating e2e forced batch test to have 1 forced tx.

Signed-off-by: Nikolay Nedkov <nikolai_nedkov@yahoo.com>
@Psykepro Psykepro force-pushed the test/forced-batches-vectors branch from 825b53f to 09f8571 Compare May 11, 2023 08:44
Comment on lines +268 to +273
/*
func uint32ToBool(value uint32) bool {
return value != 0
}
*/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remove this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will in next PR

@Psykepro Psykepro merged commit b178240 into develop May 11, 2023
@Psykepro Psykepro deleted the test/forced-batches-vectors branch May 11, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store l2block and transaction records for ForcedBatch transactions Implement tests for forced batches
4 participants