-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix memory reading for custom tracers when memory is smaller than stack values #2140
Merged
ToniRamirezM
merged 15 commits into
main
from
hotfix/custom-tracer-read-stack-and-memory
Jun 6, 2023
Merged
fix memory reading for custom tracers when memory is smaller than stack values #2140
ToniRamirezM
merged 15 commits into
main
from
hotfix/custom-tracer-read-stack-and-memory
Jun 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnusmor
previously approved these changes
May 30, 2023
… root on saving L2 blocks. Signed-off-by: Nikolay Nedkov <nikolai_nedkov@yahoo.com>
…th-hotfix unit tests: adding missing tests. and fixing forced batches old state root on saving L2 blocks.
GloWE3
previously approved these changes
Jun 5, 2023
ToniRamirezM
approved these changes
Jun 6, 2023
ARR552
pushed a commit
that referenced
this pull request
Jun 6, 2023
tclemos
pushed a commit
that referenced
this pull request
Jun 6, 2023
Ameralameri
reviewed
Jul 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2139.
Closes #2141.
Closes #2142.
Closes #2141.
What does this PR do?
default tracer fixes:
custom tracer fixes:
Reviewers
Main reviewers:
@agnusmor
@ToniRamirezM