Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix memory reading for custom tracers when memory is smaller than stack values #2140

Merged
merged 15 commits into from
Jun 6, 2023

Conversation

tclemos
Copy link
Contributor

@tclemos tclemos commented May 30, 2023

Closes #2139.
Closes #2141.
Closes #2142.
Closes #2141.

What does this PR do?

default tracer fixes:

  • suppressed unnecessary STOP structure log provided by new executor version for internal transactions

custom tracer fixes:

  • fix memory reading for custom tracers when memory is smaller than stack values
  • fix how to handle revert opcodes for internal transactions
  • fix how to handle consecutive calls with internal delegate calls
  • fix gas and gas used
  • fix value for internal transactions

Reviewers

Main reviewers:

@agnusmor
@ToniRamirezM

@tclemos tclemos added this to the v0.1.0 milestone May 30, 2023
@tclemos tclemos self-assigned this May 30, 2023
@cla-bot cla-bot bot added the cla-signed label May 30, 2023
agnusmor
agnusmor previously approved these changes May 30, 2023
state/transaction.go Outdated Show resolved Hide resolved
state/transaction.go Outdated Show resolved Hide resolved
state/transaction.go Outdated Show resolved Hide resolved
GloWE3
GloWE3 previously approved these changes Jun 5, 2023
@ToniRamirezM ToniRamirezM merged commit c3d0bd4 into main Jun 6, 2023
13 checks passed
@ToniRamirezM ToniRamirezM deleted the hotfix/custom-tracer-read-stack-and-memory branch June 6, 2023 14:24
Copy link

@Ameralameri Ameralameri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants