cherry-pick: Synchronized inform field state.batch.closing_reason from DB #3366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* decode old ETROG processBatches use ETROG contract * fix sanity genesis
joanestebanr
requested review from
ARR552,
ToniRamirezM and
tclemos
as code owners
agnusmor
approved these changes
Feb 26, 2024
joanestebanr
deleted the
feature/cherry-pick-3243-sync_add_closing_reason_to_batch_table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3243
original PR: #3245
The field
state.batch.closing_reasonis use bysequencerto report the reason that close this batch. Make sense thatsyncrhonizerwhen close a batch also report this value.The suggested values are:
Sync: genesis: Batch genesisSync L1: sequenced: a batch have been created and closed due a sequencedBatch eventSync L1: injectedinjected batch (update etrog batch event)Sync L2: trusted: a batch synchronized from TrustedNodeAnd so on....And so on....
What does this PR do?
Reviewers
Main reviewers:
Codeowner reviewers: