Update permission less rpc's batch time #3580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjg555543
requested review from
ARR552,
joanestebanr,
ToniRamirezM and
tclemos
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It fixes the issue of inaccurate timestamps on RPC nodes when batching, which maybe leads to older batch timestamps being greater than newer ones after database recovery.
Issue:
The trust batch of the Permitionless RPC retrieves directly from theTrust RPC and using local timestamps, but there's no subsequent update.
Solution:
Upon detecting an L1 sequence batch event, the Permitionless RPC updates its local batch timestamp to the MaxSequenceTimestamp within L1.
Reviewers
Main reviewers:
Codeowner reviewers: