New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential nil pointer for worker #3585

Open

ylsGit wants to merge 3 commits into 0xPolygonHermez:develop from okx:yls/worker-nil-pointer

ylsGit commented Apr 23, 2024

What does this PR do?

It fixs potential nil pointer for Sequencer.worker

line 96 loadFromPool-->addTxToWorker-->s.worker
line 103 s.worker = xxx

If 1 finishes before 2, there will be a panic.

Reviewers

Main reviewers:

@john
@doe

Codeowner reviewers:

@-Alice
@-Bob


          fix potential null pointer for worker

9475bd1

ylsGit requested review from ToniRamirezM, dpunish3r and agnusmor as code owners

April 23, 2024 10:15

cla-bot bot commented Apr 23, 2024

We require contributors/corporates @ylsGit to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

ylsGit changed the title ~~fix potential nil pointer for worker~~ Fix potential nil pointer for worker


          Update sequencer.go

dafa49e

cla-bot bot added the cla-signed label


          Update sequencer.go

9f1e090

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ToniRamirezM Awaiting requested review from ToniRamirezM ToniRamirezM is a code owner

dpunish3r Awaiting requested review from dpunish3r dpunish3r is a code owner

agnusmor Awaiting requested review from agnusmor agnusmor is a code owner

At least 1 approving review is required to merge this pull request.