Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/counter tests #223

Merged
merged 4 commits into from
Jan 13, 2023
Merged

Feature/counter tests #223

merged 4 commits into from
Jan 13, 2023

Conversation

ignasirv
Copy link
Contributor

@ignasirv ignasirv commented Jan 9, 2023 •
edited

Implementation of counters unit testing mechanism. Check README for usage details

  • Updated counter checks with new counter system (check counters at the lowest level of a function)

@cla-bot cla-bot bot added the cla-signed label Jan 9, 2023
@ignasirv
First approach
ad8770b 
Apply jmpnz


More functions


Finished counters tests from utils


Setup gha for counter tests


Arith counters tests
@ignasirv ignasirv force-pushed the feature/counter-tests branch 2 times, most recently from 1618e07 to d1aa7b4 Compare January 10, 2023 16:21
@ignasirv ignasirv marked this pull request as ready for review January 11, 2023 12:58
krlosMata
krlosMata approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@krlosMata krlosMata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

@krlosMata krlosMata merged commit 5c05b98 into develop Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krlosMata krlosMata krlosMata approved these changes

@invocamanman invocamanman Awaiting requested review from invocamanman invocamanman is a code owner

@laisolizq laisolizq Awaiting requested review from laisolizq laisolizq is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ignasirv @krlosMata