Skip to content

Commit

Permalink
Addressing comments
Browse files Browse the repository at this point in the history
  • Loading branch information
begmaroman committed Jun 7, 2024
1 parent 759b6b1 commit cc091bd
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
4 changes: 2 additions & 2 deletions dataavailability/dataavailability.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ func New(backend DABackender) (*DataAvailability, error) {
da := &DataAvailability{
backend: backend,
}
err := da.backend.Init()
return da, err

return da, da.backend.Init()
}

// PostSequence sends the sequence data to the data availability backend, and returns the dataAvailabilityMessage
Expand Down
6 changes: 4 additions & 2 deletions dataavailability/datacommittee/datacommittee.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ func (d *Backend) Init() error {
if committee != nil {
d.committeeMembers = committee.Members
if len(committee.Members) > 0 {
selectedCommitteeMember = rand.Intn(len(committee.Members)) //nolint:gosec
selectedCommitteeMember = rand.Intn(len(committee.Members) - 1) //nolint:gosec
}
}
d.selectedCommitteeMember = selectedCommitteeMember
Expand Down Expand Up @@ -279,17 +279,19 @@ func (d *Backend) getCurrentDataCommittee() (*DataCommittee, error) {
if err != nil {
return nil, fmt.Errorf("error getting CommitteeHash from L1 SC: %w", err)
}

reqSign, err := d.dataCommitteeContract.RequiredAmountOfSignatures(&bind.CallOpts{Pending: false})
if err != nil {
return nil, fmt.Errorf("error getting RequiredAmountOfSignatures from L1 SC: %w", err)
}

members, err := d.getCurrentDataCommitteeMembers()
if err != nil {
return nil, err
}

return &DataCommittee{
AddressesHash: common.Hash(addrsHash),
AddressesHash: addrsHash,
RequiredSignatures: reqSign.Uint64(),
Members: members,
}, nil
Expand Down

0 comments on commit cc091bd

Please sign in to comment.