Validium #32
Merged
Validium #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code Feature/remove unnecesary code
Add GHA to push image on TAG
# Conflicts: # .github/workflows/push-docker-tagged.yml # go.mod # go.sum # sequencesender/sequencesender.go # state/datastream.go # state/interfaces.go
# Conflicts: # encoding/encoding.go # etherman/etherman.go # go.mod # go.sum # state/batch.go # state/errors.go # state/forkid.go # state/genesis.go # state/helper.go # state/transaction.go # state/types.go
# Conflicts: # config/network.go
# Conflicts: # go.sum
# Conflicts: # go.mod # go.sum # state/encoding_batch_v2_test.go
# Conflicts: # go.mod # go.sum
ToniRamirezM
approved these changes
Jun 7, 2024
| type DataCommittee struct { | ||
| AddressesHash common.Hash | ||
| Members []DataCommitteeMember | ||
| RequiredSignatures uint64 |
There was a problem hiding this comment.
Will we ever require 2^64 signatures?
There was a problem hiding this comment.
This type is used to be compatible with the smart contract since this value comes from chain.
| "error getting data from DAC node %s at %s: %s", | ||
| member.Addr.Hex(), member.URL, err, | ||
| ) | ||
| d.selectedCommitteeMember = (d.selectedCommitteeMember + 1) % len(d.committeeMembers) |
There was a problem hiding this comment.
No sure about this + 1
There was a problem hiding this comment.
the idea is to iterate over the different committee members, as we are good as long as one of them replies. If one member is not answering, then we try the next one
| "error getting data from DAC node %s at %s: %s", | ||
| member.Addr.Hex(), member.URL, unexpectedHash, | ||
| ) | ||
| d.selectedCommitteeMember = (d.selectedCommitteeMember + 1) % len(d.committeeMembers) |
|
arnaubennassar
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.