Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Load token vault and did from k8s mounted volume #426

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

x1m3
Copy link
Contributor

@x1m3 x1m3 commented Jun 22, 2023

If vault or did env vars are not set, we will try to download from the mounted volume we use in k8s configuration. If not found we will fail.

@x1m3 x1m3 requested review from a team as code owners June 22, 2023 15:59
@x1m3 x1m3 changed the base branch from main to develop June 22, 2023 16:00
@x1m3
Copy link
Contributor Author

x1m3 commented Jun 23, 2023

LGTM

Copy link
Contributor

@martinsaporiti martinsaporiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martinsaporiti martinsaporiti merged commit 8f2cd89 into develop Jun 26, 2023
3 checks passed
@martinsaporiti martinsaporiti deleted the k8s_tokenvault_and_did_from_volume branch June 26, 2023 10:08
@javip97 javip97 changed the title Load token vault and did from k8s mounted volume feat: Load token vault and did from k8s mounted volume Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants