Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: split cli and client into workspace #407
refactor: split cli and client into workspace #407
Changes from 5 commits
6f5d782
83421cc
6b37542
4e07a0c
8b5a8ec
49ad991
19fb973
c9a763c
6349fd6
f715555
23c8ede
1131acf
6aaa2f9
256128b
a6d4a63
be199e2
9183699
72a1619
a9661b9
dacf7a6
49b2c6e
44b268b
6a44628
76e35e7
e844b0d
b8520ae
afd268a
c73d780
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be able to leave
default
as empty, and remove optional dependencies.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to above comments, I'm not sure we need the
client
submodule any more. Contents of this file should probably go intolib.rs
and all other files brought up one level.This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: let's make sure these are sorted in alphabetical order.