Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dyncall assembly instruction, tests, and docs #1080

Merged
merged 3 commits into from Oct 4, 2023

Conversation

grjte
Copy link
Collaborator

@grjte grjte commented Sep 28, 2023

This PR addresses part of #728, and exposes the new dynamic node capabilities to the user via a new dyncall instruction which changes context before executing code that is dynamically specified via the stack.

This is implemented by setting the target of CALL to the constant hash value of DYN.

  • add dyncall instruction
  • add tests
  • add docs

Questions:

  • I'm waiting for confirmation on the approach before writing docs, so please confirm
  • Please let me know where you want this documentation to go

@grjte grjte requested a review from bobbinth September 28, 2023 14:08
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I have only one comment in addition to the comments I left in #1078.

miden/tests/integration/flow_control/mod.rs Outdated Show resolved Hide resolved
@grjte grjte force-pushed the grjte-asm-dyncall branch 2 times, most recently from 5e5f8b1 to 5ec384c Compare October 3, 2023 07:52
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Thank you! Let's merge after #1078.

@bobbinth bobbinth changed the title Add dyncall assembly instruction, tests, and docs Add dyncall assembly instruction, tests, and docs Oct 4, 2023
@bobbinth bobbinth merged commit 4895473 into grjte-asm-dynexec Oct 4, 2023
15 checks passed
@bobbinth bobbinth deleted the grjte-asm-dyncall branch October 4, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants