Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement stdlib structure #121

Merged
merged 4 commits into from Feb 23, 2022
Merged

Implement stdlib structure #121

merged 4 commits into from Feb 23, 2022

Conversation

bobbinth
Copy link
Contributor

@bobbinth bobbinth commented Feb 20, 2022 •
edited

This PR implements standard library structure as discussed in #80. Specifically:

  • Add Library trait to the core crate.
  • Add first version of stdlib crate.
  • Implement parsing of imports and invocation of imported procedures.

One thing left to future PRs: I'm currently using unsafe code to achieve interior mutability in the Assembler (here). It would be good to do it in a safe way via RefCell or something similar.

@bobbinth bobbinth marked this pull request as ready for review February 22, 2022 20:55
grjte
grjte approved these changes Feb 23, 2022
View reviewed changes
Copy link
Collaborator

@grjte grjte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

assembly/src/context/mod.rs Outdated Show resolved Hide resolved
stdlib/build.rs Outdated Show resolved Hide resolved
@bobbinth bobbinth merged commit e9bddec into next Feb 23, 2022
@bobbinth bobbinth deleted the stdlib branch February 23, 2022 17:47
This was referenced Feb 23, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grjte grjte grjte approved these changes

@itzmeanjan itzmeanjan Awaiting requested review from itzmeanjan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bobbinth @grjte