Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate new ilog2 and cto instructions into MMR #1269

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

Fumuran
Copy link
Contributor

@Fumuran Fumuran commented Mar 5, 2024

After implementation of the new ilog2 and cto instructions it became possible to use them directly in the implementation of the MMR.
This PR removes the special implementations of ilog2 and cto instructions in the MMR and uses identical assembly instructions instead.

Copy link
Contributor

@hackaugusto hackaugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat. lgtm

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@bobbinth
Copy link
Contributor

bobbinth commented Mar 5, 2024

One question: does this break anything in miden-base (i.e., because MAST roots are now different)? (i don't think it should, but would be good to double-check)

@Fumuran
Copy link
Contributor Author

Fumuran commented Mar 5, 2024

I checked: no, it doesn't break anything, I managed to build the miden-base repo and successfully run all tests.

@Fumuran Fumuran merged commit b5f2fa6 into next Mar 5, 2024
15 checks passed
@Fumuran Fumuran deleted the andrew-integrate-ilog2-into-MMR branch March 5, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants