Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the immediate values for lt, lte, gt and gte comparison instructions #1348

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

Fumuran
Copy link
Contributor

@Fumuran Fumuran commented Jun 4, 2024

This PR makes it possible to use lt, lte, gt and gte comparison instructions with an immediate values.

Related issue: #1326

@Fumuran Fumuran linked an issue Jun 4, 2024 that may be closed by this pull request
@Fumuran
Copy link
Contributor Author

Fumuran commented Jun 4, 2024

Clippy is failing because of the comments formatting, which I have fixed in the #1328 PR, so probably it won't be a problem after we merge it.

Copy link
Contributor

@bitwalker bitwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Definitely a convenient change for the compiler, as these types of comparisons are exceedingly common.

@Fumuran Fumuran force-pushed the andrew-add-imm-for-comparison-instructions branch from 971279f to bcaf2c5 Compare June 6, 2024 22:54
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

We should probably do the same thing for u32 comparison instructions (in a different PR). Let's create an issue for this.

@Fumuran Fumuran merged commit 1a65242 into next Jun 7, 2024
15 checks passed
@Fumuran Fumuran deleted the andrew-add-imm-for-comparison-instructions branch June 7, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

comparison instructions should accept immediate values
3 participants