Support the immediate values for u32 comparison instructions
#1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Looks good! Thank you!
Would probably be good for @bitwalker to take a look as well as he's more familiar with the assembler structure than I am.
Fumuran
force-pushed
the
andrew-imm-values-for-u32-comp-instrs
branch
from
b4f9b49
to
26f84bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to use
u32lt,u32lte,u32gt,u32gte,u32minandu32maxcomparison instructions with an immediate values.Related issue: #1350