Refactor hash chiplet constants and chiplets trace tests module #344
Conversation
grjte
force-pushed
the
refactor-chiplets
branch
from
9113562
to
91a8598
Compare
| @@ -257,7 +257,7 @@ pub fn parse_storew( | |||
| /// values (represented by 32-bit limbs), divides one value by another, and injects the quotient | |||
| /// and the remainder into the advice tape. | |||
| pub fn parse_adv_inject( | |||
| span_ops: &mut Vec<Operation>, | |||
| span_ops: &mut [Operation], | |||
There was a problem hiding this comment.
I think the comment above needs to be updated as well - but could be done in a different PR (maybe just leave a TODO for now?).
There was a problem hiding this comment.
I don't understand what's needed here - I was just fixing a clippy warning. Is the issue with the comment that the code is actually appending to the decorators rather than to span_ops? I'm not going to leave a TODO, as I'm not sure what to put, but I'm happy to open an issue once I understand what's needed. For now I'm going to merge this PR so I can move forward to wrap up the b_chip column.
There was a problem hiding this comment.
Sounds good! Yes, the changes are that we are appending to decorators, and actually span_ops does not need to be mutable here.
This PR is a precursor to the PR that will complete the inclusion of the hasher lookups in the b_chip bus column. It includes the following refactors:
coreand switches imports to go through core::chiplets::hasher (rather than core::hasher)airtocore