Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update u32 proptests in the processor to only test valid u32 values #89

Merged
merged 3 commits into from
Jan 31, 2022
Merged

Update u32 proptests in the processor to only test valid u32 values #89

merged 3 commits into from
Jan 31, 2022

Conversation

grjte
Copy link
Collaborator

@grjte grjte commented Jan 31, 2022

This PR addresses #79

  • Removes all execution failure checks from proptests in the u32_tests in the processor
  • Updates all u32 proptests to generate valid random u32 values

@grjte grjte requested a review from bobbinth January 31, 2022 08:19
@grjte grjte changed the title test: update u32 proptests in the processor to only test valid u32 values Update u32 proptests in the processor to only test valid u32 values Jan 31, 2022
@grjte grjte mentioned this pull request Jan 31, 2022
Merged
bobbinth
bobbinth approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@bobbinth bobbinth merged commit 818b1d3 into 0xPolygonMiden:next Jan 31, 2022
@bobbinth bobbinth mentioned this pull request Jan 31, 2022
Closed
@grjte grjte deleted the pr/proc-u32-proptests branch January 31, 2022 21:17
@grjte grjte mentioned this pull request Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grjte @bobbinth