Fix u32 assembly parsers for shift/rotate ops to allow b = 0 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
requested changes
Feb 2, 2022
|
Oh - and one other thing: could you make sure (that's for linux/macos, on windows the syntax might be slightly different) |
willyrgf
force-pushed
the
pr/shift-rotate-ops
branch
3 times, most recently
from
2f17f41
to
8a28195
Compare
Yes, I usually use squash commits in the "PR", but I don't know if github have this feature. Done. |
That's passing now! Nice to know about that, already save it here. |
according in the specs fix: parse_u32shl and the test according the spec to allow value b = 0 fix: parse_u32shr and the test according the spec to allow value b = 0 fix: parse_u32rotl and the test according the spec to allow value b = 0 fix: parse_u32rotr and the tests according the spec to allow value b = 0 mend
willyrgf
force-pushed
the
pr/shift-rotate-ops
branch
from
8a28195
to
74ec94d
Compare
bobbinth
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #76, fix the parsers
parse_u32shl,parse_u32shr,parse_u32rotl,parse_u32rotrfor shift/rotate ops to allow parameter value of 0 <= b <= 31, according to the assembly specs. Also, adjusted the tests to this parsers added in #75 to validate thenewenforcing parameter bounds.