chore: Require excluded sources to be manually updated for a new chain #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyu-c
force-pushed
the
chore/excluded-sources
branch
2 times, most recently
from
7b20393
to
aca8433
Compare
kyu-c
changed the title
EXCLUDED_SOURCES to be manually updated on a new chainEXCLUDED_SOURCES to be manually updated for a new chain
kyu-c
force-pushed
the
chore/excluded-sources
branch
from
aca8433
to
07091ab
Compare
idokleinman
approved these changes
Aug 5, 2022
dekz
approved these changes
Aug 8, 2022
kyu-c
force-pushed
the
chore/excluded-sources
branch
from
07091ab
to
b5c8169
Compare
|
deploy production all |
|
deploy production goerli |
|
deploy production fantom |
idokleinman
changed the title
EXCLUDED_SOURCES to be manually updated for a new chain
|
deploy production all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NativeSourcewhich is unlikely to be desired value for a new chain.It would be less error-prone to fail fast and require excluded sources to be manually specified for a new chain.
Testing Instructions
Checklist
Update documentation as needed. Website Documentation PR:
Prefix PR title with
[WIP]if necessary.Add tests to cover changes as needed.
Test changes on the staging environment with Matcha API Staging.
For more information see
0x API Matcha smoke test runbookin Quip.