New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix errors checks for isNull lodash call #28

Merged

LogvinovLeon merged 1 commit into 0xProject:master from 0xean:bug/fix-error-checks

Jan 21, 2019

Contributor

0xean commented Jan 16, 2019

Calls to isUndefined results in order's never getting pruned.

_.isUndefined(null);
// => false


          fix errors checks for isNull lodash call

f130914

dekz requested a review from LogvinovLeon

January 17, 2019 00:41

Member

dekz commented Jan 17, 2019

Thanks for the fix @pelsasser. For reference here is the order watcher call back where null is provided.

dekz approved these changes

View reviewed changes

dekz mentioned this pull request

OrderWatcher issue #26

Closed

LogvinovLeon merged commit f130914 into 0xProject:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment