Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(style / static) Markets dropdown #62

Closed
gabitoesmiapodo opened this issue Feb 22, 2019 · 0 comments · Fixed by #71
Closed

(style / static) Markets dropdown #62

gabitoesmiapodo opened this issue Feb 22, 2019 · 0 comments · Fixed by #71
Assignees
@gabitoesmiapodo

Comments

@gabitoesmiapodo
Copy link
Contributor

gabitoesmiapodo commented Feb 22, 2019 •
edited by pablofullana
Loading

screen shot 2019-02-22 at 16 04 53
@gabitoesmiapodo gabitoesmiapodo self-assigned this Feb 22, 2019
@gabitoesmiapodo gabitoesmiapodo mentioned this issue Feb 22, 2019
Closed
gabitoesmiapodo added a commit that referenced this issue Feb 26, 2019
@gabitoesmiapodo
Merge branch 'development' into feature/#62-style-markets-dropdown
81ad3a1 
* development:
  Move known_tokens to utils.
  Make known_tokens easier to test.
  Make getTokenIconNameBySymbol more concise.
  (add) buy / sell token text style
  (add) buy / sell form styles
  (add) base card style - (add) buy / sell tabs
  Add common/icons/token_icons.
  Set known token info to common/tokens_meta_data.
  Add BuySell component in left sidebar
  Rename UIOrderSide to OrderSide
  Add BuySell component
  Expose HTTPClient in Relayer
  Make card title optional
  Move non-pure utils to services
gabitoesmiapodo added a commit that referenced this issue Feb 26, 2019
@gabitoesmiapodo
Merge branch 'development' into feature/#62-style-markets-dropdown
9da724a 
* development:
  Changed default value of My Size from '0.00' to '-'
  Added tests files
  Fixed bug based on PR feedback
  Refactored "My Size" feature based on Feedback  -Added tests  -Moved getMySize logic to selector
  Adds "My Size Column"  -Now before rendering the orderBook list, a "My Size" array is generated in order to display it on the orderBook
@gabitoesmiapodo gabitoesmiapodo mentioned this issue Feb 26, 2019
Merged
fvictorio pushed a commit that referenced this issue Feb 27, 2019
Merge pull request #71 from 0xProject/feature/#62-style-markets-dropdown
beb4fbd 
(Feature / Static Components) Markets dropdown - Trade price / 24hr change
birimbau pushed a commit to birimbau/VeriDex that referenced this issue Jan 4, 2020
@gabitoesmiapodo
Merge branch 'development' into feature/0xProject#62-style-markets-dr…
2a63279 
…opdown

* development:
  Move known_tokens to utils.
  Make known_tokens easier to test.
  Make getTokenIconNameBySymbol more concise.
  (add) buy / sell token text style
  (add) buy / sell form styles
  (add) base card style - (add) buy / sell tabs
  Add common/icons/token_icons.
  Set known token info to common/tokens_meta_data.
  Add BuySell component in left sidebar
  Rename UIOrderSide to OrderSide
  Add BuySell component
  Expose HTTPClient in Relayer
  Make card title optional
  Move non-pure utils to services
birimbau pushed a commit to birimbau/VeriDex that referenced this issue Jan 4, 2020
@gabitoesmiapodo
Merge branch 'development' into feature/0xProject#62-style-markets-dr…
4922b06 
…opdown

* development:
  Changed default value of My Size from '0.00' to '-'
  Added tests files
  Fixed bug based on PR feedback
  Refactored "My Size" feature based on Feedback  -Added tests  -Moved getMySize logic to selector
  Adds "My Size Column"  -Now before rendering the orderBook list, a "My Size" array is generated in order to display it on the orderBook
birimbau pushed a commit to birimbau/VeriDex that referenced this issue Jan 4, 2020
Merge pull request 0xProject#71 from 0xProject/feature/0xProject#62-s…
b4171f7 
…tyle-markets-dropdown

(Feature / Static Components) Markets dropdown - Trade price / 24hr change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabitoesmiapodo gabitoesmiapodo

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@fvictorio @gabitoesmiapodo